Skip to content

Use wrappers to complete SciPy and NumPy interface namespaces #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 26, 2025
Merged

Use wrappers to complete SciPy and NumPy interface namespaces #226

merged 3 commits into from
Sep 26, 2025
+53 −4

Conversation

ndgrigorian
Copy link
Collaborator

@ndgrigorian ndgrigorian commented Sep 25, 2025 •
edited
Loading

This PR proposes using wrappers for fftfreq, fftshift, ifftshift, and rfftfreq instead of importing them from scipy.fft or numpy.fft directly

These thin wrappers can avoid infinite recursion of dependencies, i.e., when importing Intel NumPy with Intel SciPy in the environment

@ndgrigorian
wrap remaining scipy functions to complete the namespace, instead of …
9b6c69d 
…importing directly

avoids circular dependencies under certain conditions
antonwolfy
antonwolfy approved these changes Sep 25, 2025
View reviewed changes
Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix LGTM! But need to add the PR to the changelog also.

@ndgrigorian
Copy link
Collaborator Author

The fix LGTM! But need to add the PR to the changelog also.

done

@ekomarova
Copy link
Collaborator

Will a change like this always require scipy as a mkl_fft dependency, or can it still be optional?

@ndgrigorian
Copy link
Collaborator Author

ndgrigorian commented Sep 26, 2025 •
edited
Loading

Will a change like this always require scipy as a mkl_fft dependency, or can it still be optional?

It can still be optional—since the scipy interface is only exposed in interfaces/__init__.py if SciPy can be imported, this doesn't change anything (scipy_fft.py already needed to import it before)

alternatively, the import could be made lazy, so we could do from scipy.fft import fftshift in the def of fftshift.

@ndgrigorian ndgrigorian merged commit 3cb11f3 into master Sep 26, 2025
85 checks passed
@ndgrigorian ndgrigorian deleted the complete-scipy-interface-namespace branch September 26, 2025 18:13
@ndgrigorian ndgrigorian changed the title Use wrappers to complete SciPy interface namespace Use wrappers to complete SciPy and NumPy interface namespaces Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ekomarova ekomarova ekomarova approved these changes

@antonwolfy antonwolfy antonwolfy approved these changes

@xaleryb xaleryb Awaiting requested review from xaleryb xaleryb is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ndgrigorian @ekomarova @antonwolfy